Add option to specify the mime type for files matching a pattern #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option is saved per added site. First time that this version is used, the option is saved for all sites. This is not different from how other options are handled but could be confusing because on subsequent updates, the option is ignored and the value is set for all sites in your config-dir, even the ones you do not update.
debbiedub
commented
Nov 5, 2023
| @@ -271,6 +271,10 @@ def help(): | |||
| print(" - index file (default is index.html)") | |||
| print(" -m, --mime-type") | |||
| print(" - mime-type of the index file (default is \"text/html\")") | |||
| print(" --mime-type-match=PATTERN=MIME/TYPE") | |||
| print(" Set mime-type for files matching PATTERN. Can be given") | |||
| print(" multiple times to match distinct patterns.") | |||
There was a problem hiding this comment.
There are a lot more to say about this but I don't think this is the place.
Among other things:
- If no files match, the mime-type will be determined my fcp3/node.py guestMimeType(filename) that in turn uses mimetypes.guess_type(filename, False).
- The order is significant, i.e.
--mime-type-match=*.gif=image/gif --mime-type-match=databasefiles/*=text/plainwill, for the filedatabasefiles/somedir/*.gifgive the mime-typeimage/gifwhile --mime-type-match=databasefiles/*=text/plain --mime-type-match=*.gif=image/gifwill give the mime-typetext/plainfor the same file name.
There was a problem hiding this comment.
Can you add that information in a file in doc/? Maybe with an example how to use this to upload a repo for dgof? Maybe as doc/freesitemgr.org ? (in org-mode format — markdown would also work)
There was a problem hiding this comment.
OK, yes. I will see if I understand the org-mode format. I will do that in another pull request.
ArneBab
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is saved per added site.
First time that this version is used, the option is saved for all sites. This is not different from how other options are handled but could be confusing because on subsequent updates, the option is ignored and the value is set for all sites in your config-dir, even the ones you do not update.